Always overwrites the existing excluding= value. Combined with get_generated_source_exclusions unconditionally seeding annotations/, a project that never had annotations/ excluded will silently gain it, and any pre-existing custom exclusions will be dropped. Parse the current attribute, merge with the new set, and write the union.

set_exclusions now parses existing, merges union, writes back as sorted: old entries preserved, new entries added, no data loss.

Windows path mismatch. .classpath files always use / for path="..." (Eclipse format), but path_utils.path_separator is \ on Windows. The prefix built here uses backslashes while absolute_path from vim.fs.find may use forward slashes — comparison silently fails. Normalize both sides to / for all classpath-string operations.

Nice catch! Added normalization for slashes

Regex-based XML editing is fragile. Only matches path="target/generated-sources" exactly — a trailing slash, single quotes, or a multiline tag will be missed. At minimum document this assumption in the module docstring; ideally use an XML parser or a more permissive pattern.

still uses regex matching, but handles both types of quotes: " and '

add_classpath_entry always returns true, and the caller ignores it anyway. Either drop the return or actually report no-op vs. insert so the caller can use it.

dropped the return

Passing vim.pesc(...) with plain = false is confusing — the pesc only matters in pattern mode, but plain mode is what you want here. Use plain = true and drop the pesc call.

Also: limit = math.huge is unbounded — on large monorepos this walk can be slow. Consider a sane cap and a warning when hit, especially since this runs synchronously at setup().

annotations/ is always seeded into exclusions regardless of whether the user's project had it. This is the root of the overwrite behavior flagged on set_exclusions. Either derive the seed from the project's existing excluding= attribute, or document clearly why annotations/ is unconditionally injected.

No logging. This silently rewrites user files. Per CLAUDE.md, use java-core.utils.log2 to log.info which .classpath was patched and which roots were added/excluded — critical for debugging an experimental feature where Maven may regenerate .classpath and silently lose the patch.

Also worth a one-line comment noting this is safe to re-run (has_classpath_entry + set_exclusions no-op make it idempotent in the common case).

added logging

Missing LuaDoc. Per CLAUDE.md, public API needs ---@ annotations. At minimum:

---@param root string
---@return boolean changed
function M.patch(root)

Runs synchronously at setup(). On large monorepos the recursive vim.fs.find walk could noticeably delay startup. Consider deferring (vim.schedule) or at least logging duration so users can see the cost.

It has to run in sync I believe, otherwise jdtls would pick up an incorrect .classpath file.
Added duration calculation.

I've ran it on quite big projects with many generated source folders, and it was working quite OK, I did not notice a major hit.

Missing test coverage:

• Idempotency — call patch() twice; second call should return false and leave the file unchanged.
• Pre-existing excluding="..." attribute — confirm the merge/overwrite behavior (ties into the annotations/ concern in the source file).
• Multi-module project with multiple .classpath files.

added 3 more tests