Hey all,
I'm from the AWS CDK project. We are a transitive client of Handlebars through Jest. After the 4.5.0 release, our canaries started failing. It's because we check whether our dependency closure does not contain unmet peer dependencies with npm ls. After Handlebars 4.5.0 was released, this is what we see:
│ │ │ ├─┬ [email protected]
│ │ │ │ └─┬ [email protected]
│ │ │ │ ├── UNMET PEER DEPENDENCY eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0
│ │ │ │ ├─┬ [email protected]
│ │ │ │ │ ├── @babel/[email protected] deduped
│ │ │ │ │ ├── [email protected]
│ │ │ │ │ ├─┬ [email protected]
│ │ │ │ │ │ ├── [email protected]
│ │ │ │ │ │ ├── [email protected]
│ │ │ │ │ │ └─┬ [email protected]
│ │ │ │ │ │ └── [email protected]
│ │ │ │ │ ├── [email protected]
│ │ │ │ │ ├── [email protected] deduped
│ │ │ │ │ ├─┬ [email protected]
│ │ │ │ │ │ └── [email protected] deduped
│ │ │ │ │ └── [email protected]
│ │ │ │ ├── [email protected]
│ │ │ │ ├─┬ [email protected]
│ │ │ │ │ ├── [email protected]
│ │ │ │ │ └── [email protected] deduped
│ │ │ │ ├── [email protected] deduped
│ │ │ │ └─┬ [email protected]
│ │ │ │ ├── [email protected]
│ │ │ │ └── [email protected] deduped
I believe the issue is this commit added a dependency on eslint-plugin-compat, which only has a devDependency on eslint (but a peer dependency on it!).
Would it be possible to release 4.5.1 that adds the dependency on "eslint": "^3.3.0"?
Thanks,
Adam
Hey all,
I'm from the AWS CDK project. We are a transitive client of Handlebars through Jest. After the 4.5.0 release, our canaries started failing. It's because we check whether our dependency closure does not contain unmet peer dependencies with
npm ls. After Handlebars4.5.0was released, this is what we see:I believe the issue is this commit added a dependency on
eslint-plugin-compat, which only has a devDependency oneslint(but a peer dependency on it!).Would it be possible to release
4.5.1that adds the dependency on"eslint": "^3.3.0"?Thanks,
Adam