You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We will have to move some files around to match the most excellent project structure you have. But over all, so long as we export the created iris client when requested, all of the iris functionality should follow that client.
We'll talk more about the merge on Wednesday during our meeting. Basically, we don't need the IRIS methods and the Catapult methods to function the same, nor even look the same. However, we should be able to create both the IRIS client and the Catapult client from the same 'SDK'. And the end user can combine the methods as they see fit.
We will probably have to move some files around. But over all, so long as
we export the created iris client when requested, all of the iris
functionality should follow that client.
We'll talk more about the merge on Wednesday during our meeting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you've checked off all these things before submitting: