Skip to content
This repository was archived by the owner on Feb 10, 2021. It is now read-only.

Boto3 style catapult#2

Merged
dtolb merged 53 commits into
masterfrom
boto3-style-catapult
Nov 16, 2016
Merged

Boto3 style catapult#2
dtolb merged 53 commits into
masterfrom
boto3-style-catapult

Conversation

@avbel

@avbel avbel commented Nov 14, 2016

Copy link
Copy Markdown
Contributor

Make sure you've checked off all these things before submitting:

  • This pull request contains 100% test coverage.
  • This pull request is completely documented. All available fields are listed in the docs with description.
  • Each public facing method should include at least one example using said method.

@dtolb

dtolb commented Nov 14, 2016

Copy link
Copy Markdown

@avbel , we should be able to add @smitchell2240 's client creation code for iris as part of the _init_.py file now? Right?

We will have to move some files around to match the most excellent project structure you have. But over all, so long as we export the created iris client when requested, all of the iris functionality should follow that client.

We'll talk more about the merge on Wednesday during our meeting. Basically, we don't need the IRIS methods and the Catapult methods to function the same, nor even look the same. However, we should be able to create both the IRIS client and the Catapult client from the same 'SDK'. And the end user can combine the methods as they see fit.

@avbel

avbel commented Nov 15, 2016

Copy link
Copy Markdown
Contributor Author

Yes. Right.

15 нояб. 2016 г. 12:43 ДП пользователь "Daniel Tolbert" <
[email protected]> написал:

@avbel https://github.com/avbel , we should be able to add
@smitchell2240 https://github.com/smitchell2240 's client creation code
for iris as part of the init.py
https://github.com/Bandwidth/python-bandwidth/blob/boto3-style-catapult/bandwidth/__init__.py
file now? Right?

https://github.com/Bandwidth/python-bandwidth/blob/steve-
working/bandwidth_sdk/client.py#L136

We will probably have to move some files around. But over all, so long as
we export the created iris client when requested, all of the iris
functionality should follow that client.

We'll talk more about the merge on Wednesday during our meeting.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC6MnHm9JcnxBCCkLhlzizRv6cuuWJFXks5q-NYSgaJpZM4KxYqm
.

@dtolb dtolb merged commit 8f59099 into master Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants