Skip to content

fixed missing pragma once in math.cpp#15

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

fixed missing pragma once in math.cpp#15
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 2, 2018

Copy link
Copy Markdown

No description provided.

@RobLoach

RobLoach commented Nov 2, 2018

Copy link
Copy Markdown
Contributor

To my knowledge, #pragma once is non-standard. Would it be okay if we switched this for a #ifndef instead?

RobLoach added a commit that referenced this pull request Nov 3, 2018
@RobLoach
Add ifndef check in the headers
6960fc0 
Fixes #14, #15, #16
@RobLoach RobLoach mentioned this pull request Nov 3, 2018
Merged
RobLoach added a commit that referenced this pull request Nov 3, 2018
@RobLoach
Add ifndef check in the headers (#17)
4f3ee02 
Fixes #14, #15, #16
@RobLoach RobLoach closed this Nov 3, 2018
@ghost

ghost commented Nov 5, 2018

Copy link
Copy Markdown
Author

I prefer pragma once because it's meanwhile supported by many compilers. But #ifndef would also be ok for me ;-)

@ghost ghost deleted the patch-1 branch November 5, 2018 06:10
@ghost

ghost commented Nov 5, 2018

Copy link
Copy Markdown
Author

Could you please provide a release with this bug fix? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobLoach