Complete overhaul for build images#137
Merged
Merged
Conversation
modified byteman installation disable libnss preload fix envsubst missing add entrypoint in indy remove dumb-init from other entrypoint replace print function update urllib add convertion of byte and string switch quarkus based services to new base remove java install& uninstall process removed dumb-init completely and add cache clean for indy remove indy user setup fix indy build rearrange indy build Dockerfile for readablility
Contributor
|
@shokakucarrier I've created a "ubi9" branch from master, can we use this branch to test these image changes? |
Contributor
Author
Done |
ligangty
reviewed
Nov 26, 2024
|
|
||
| EXPOSE 8080 8081 8000 | ||
|
|
||
| USER 1001 |
Contributor
There was a problem hiding this comment.
So just curious that where is user 1001 is created and mapped?
Contributor
Author
There was a problem hiding this comment.
it doesn't matter, this is just for OpenShift arbitary user execution, I tested this on GPC it works with this line and without user wrapper script
ligangty
approved these changes
Nov 27, 2024
ligangty
left a comment
ligangty
left a comment
Contributor
There was a problem hiding this comment.
Generally lGTM. Let's use this for devel testing after merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to UBI9 and completely ditched JDK 1.8 and Python2
use latest instead of jdk11 tag for base image because JDK 1.8 version no longer exist
removed setting users process for indy
enhancement of readability for indy Dockerfile
removed dumb-init
removed unnecessary packages in base image
removed redundant files
Require rebuild for every services