This repository was archived by the owner on Apr 17, 2021. It is now read-only.
Add support for covers from URLs. Add support for PNG covers.#58
Merged
Conversation
marccarre
force-pushed
the
issues/54-covers-from-url
branch
from
bc4d8c1 to
408df3d
Compare
… read-only purposes This way, - `Deck.image_url` can strictly map to Tinycards API's `imageUrl`, - `Deck.cover_image_url` can strictly map to Tinycards API's `coverImageUrl`, - `Deck.cover` is only used for cover upload purposes, which is hopefully clearer, or at least, matches more closely Tinycards API's behaviour.
marccarre
force-pushed
the
issues/54-covers-from-url
branch
from
408df3d to
e0c1bcb
Compare
Contributor
Author
|
Now rebased on top of latest |
Pull Request Test Coverage Report for Build 269
💛 - Coveralls |
Contributor
Author
|
@floscha, would you be fine releasing a new version of |
Owner
|
Hey @marccarre, I'm pretty busy with work these days but I'll have a closer look tonight and then merge the PR and release a new version if everything looks right (which so far it does) 🙂 |
Owner
|
The code looks fine to me. Also, I've tried it out on some of my actual decks and it worked like a charm so I don't see a reason not to merge. Thanks again for the quality work! |
Owner
|
As promised, I also published a new version to PyPI. |
Contributor
Author
|
Thank you @floscha! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54.
Changelog:
cover(only used to trigger cover upload), andimageUrl&coverImageUrl(only used to reflect Tinycards' view of the world).N.B.: Currently rebased on top ofissues/50-quiz-and-tts-options, itself rebased on top ofissues/55-more-user-id-cleanupfor tests to pass. Will rebase on top ofmasteronce #56 and #57 are merged.