Add getNumberValue function#385
Merged
Merged
Conversation
Omega-Ariston
approved these changes
Aug 22, 2019
Alanscut
requested changes
Apr 2, 2020
Alanscut
left a comment
Alanscut
left a comment
Collaborator
There was a problem hiding this comment.
Thanks your contributions, would you mind making some changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :) I use cJSON very well, but i found cJSON don't have getNumberValue.
So I add it. If cJSON object is not number type. I return Nan(not a number).
And i also follow Coding style which is in CONTRIBUTING.md.
At last i Add Unit Test to misc_tests.c, and test is successful.
Check and merge plz. thank u :)