fix: some bugs in detach and replace by miaoerduo · Pull Request #456 · DaveGamble/cJSON

miaoerduo · 2020-04-03T03:54:57Z

set list head's prev when parse_object and parse_array
detach the first item when array size is 1
detach the last item
replace the first item when array size is 1
replace the last item

Alanscut · 2020-04-03T08:06:17Z

 success:
    input_buffer->depth--;

+    if (head != NULL) {


@miaoerduo thanks your suggestion! but this change make the testcase fail, I have to make some changes for it.

Maybe the 0th is unnecessary? How about the others? I have test these in my project. :P

No, it's needed. compiling it with option cmake ENABLE_VALGRIND=On .. when make check, memory check is very important.

Sorry, I have commited with company's email.
So I have to changed the email in commits and force pushed again.

May my modification be merged into this project?
Is there any other thing I could do?
I haven't contributed to a project with so many stars!

This version is released no more than 24 hours since you make this contribution, you have done a good job :), before I merge it, I need some time to make sure it won't introduce any problem.

Wow! Thank YOU very much!

…lacing the last item

@sappo

1.7.18 (May 13, 2024) ====== * Add NULL check to cJSON_SetValuestring()(CVE-2024-31755), see #839 and #840 * Remove non-functional list handling of compiler flags, see #851 * Fix heap buffer overflow, see #852 * Remove misused optimization flag -01, see #854 * Set free'd pointers to NULL whenever they are not reassigned immediately after, see #855 and #833 1.7.17 (Dec 26, 2023) ====== * Fix null reference in cJSON_SetValuestring(CVE-2023-50472), see #809 * Fix null reference in cJSON_InsertItemInArray(CVE-2023-50471), see #809 and #810 1.7.16 (Jul 5, 2023) ====== * Add an option for ENABLE_CJSON_VERSION_SO in CMakeLists.txt, see #534 * Add cmake_policy to CMakeLists.txt, see #163 * Add cJSON_SetBoolValue, see #639 * Add meson documentation, see #761 * Fix memory leak in merge_patch, see #611 * Fix conflicting target names 'uninstall', see #617 * Bump cmake version to 3.0 and use new version syntax, see #587 * Print int without decimal places, see #630 * Fix 'cjson_utils-static' target not exist, see #625 * Add allocate check for replace_item_in_object, see #675 * Fix a null pointer crash in cJSON_ReplaceItemViaPointer, see #726 1.7.15 (Aug 25, 2021) ====== * Fix potential core dumped for strrchr, see [#546](DaveGamble/cJSON#546) * Fix null pointer crash in cJSON_CreateXxArray, see [#538](DaveGamble/cJSON#538) * Fix several null pointer problems on allocation failure, see [#526](DaveGamble/cJSON#526) * Fix a possible dereference of null pointer, see [#519](DaveGamble/cJSON#519) * Fix windows build failure about defining nan, see [#518](DaveGamble/cJSON#518) 1.7.14 (Sep 3, 2020) ====== * Optimize the way to find tail node, see [#503](DaveGamble/cJSON#503) * Fix WError error on macosx because NAN is a float. Thanks @sappo, see [#484](DaveGamble/cJSON#484) * Fix some bugs in detach and replace. Thanks @miaoerduo, see [#456](DaveGamble/cJSON#456) Signed-off-by: Andre McCurdy <[email protected]>

@sappo

1.7.18 (May 13, 2024) ====== * Add NULL check to cJSON_SetValuestring()(CVE-2024-31755), see #839 and #840 * Remove non-functional list handling of compiler flags, see #851 * Fix heap buffer overflow, see #852 * Remove misused optimization flag -01, see #854 * Set free'd pointers to NULL whenever they are not reassigned immediately after, see #855 and #833 1.7.17 (Dec 26, 2023) ====== * Fix null reference in cJSON_SetValuestring(CVE-2023-50472), see #809 * Fix null reference in cJSON_InsertItemInArray(CVE-2023-50471), see #809 and #810 1.7.16 (Jul 5, 2023) ====== * Add an option for ENABLE_CJSON_VERSION_SO in CMakeLists.txt, see #534 * Add cmake_policy to CMakeLists.txt, see #163 * Add cJSON_SetBoolValue, see #639 * Add meson documentation, see #761 * Fix memory leak in merge_patch, see #611 * Fix conflicting target names 'uninstall', see #617 * Bump cmake version to 3.0 and use new version syntax, see #587 * Print int without decimal places, see #630 * Fix 'cjson_utils-static' target not exist, see #625 * Add allocate check for replace_item_in_object, see #675 * Fix a null pointer crash in cJSON_ReplaceItemViaPointer, see #726 1.7.15 (Aug 25, 2021) ====== * Fix potential core dumped for strrchr, see [#546](DaveGamble/cJSON#546) * Fix null pointer crash in cJSON_CreateXxArray, see [#538](DaveGamble/cJSON#538) * Fix several null pointer problems on allocation failure, see [#526](DaveGamble/cJSON#526) * Fix a possible dereference of null pointer, see [#519](DaveGamble/cJSON#519) * Fix windows build failure about defining nan, see [#518](DaveGamble/cJSON#518) 1.7.14 (Sep 3, 2020) ====== * Optimize the way to find tail node, see [#503](DaveGamble/cJSON#503) * Fix WError error on macosx because NAN is a float. Thanks @sappo, see [#484](DaveGamble/cJSON#484) * Fix some bugs in detach and replace. Thanks @miaoerduo, see [#456](DaveGamble/cJSON#456) Signed-off-by: Andre McCurdy <[email protected]>

miaoerduo force-pushed the master branch from 1ea1682 to 11cbdd5 Compare April 3, 2020 06:10

miaoerduo changed the title ~~feat: set list head's prev in parse_array and parse_object~~ fix: some bugs in detach and replace Apr 3, 2020

Alanscut reviewed Apr 3, 2020

View reviewed changes

miaoerduo added 3 commits April 3, 2020 17:20

feat: set list head's prev in parse_array and parse_object

3999b12

fix: error list head's prev when detach the last item

a65abf2

fix: errors in replacing the first item when array_size is 1, and rep…

cb4661c

…lacing the last item

miaoerduo force-pushed the master branch from baf5af5 to cb4661c Compare April 3, 2020 09:21

Alanscut added the needs-investigation label Apr 3, 2020

Alanscut approved these changes May 6, 2020

View reviewed changes

Alanscut merged commit a82449f into DaveGamble:master May 6, 2020

Alanscut removed the needs-investigation label May 6, 2020

Alanscut mentioned this pull request May 6, 2020

array's item should be in the list #472

Merged

Alanscut mentioned this pull request Sep 2, 2020

Possibly serious bugs in add_item_to_array in 1.7.13 #499

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: some bugs in detach and replace#456

fix: some bugs in detach and replace#456
Alanscut merged 3 commits into
DaveGamble:masterfrom
miaoerduo:master

miaoerduo commented Apr 3, 2020 •

edited

Loading

Uh oh!

Alanscut Apr 3, 2020

Uh oh!

miaoerduo Apr 3, 2020

Uh oh!

Alanscut Apr 3, 2020

Uh oh!

miaoerduo Apr 3, 2020

Uh oh!

miaoerduo Apr 3, 2020

Uh oh!

Alanscut Apr 3, 2020

Uh oh!

miaoerduo Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

miaoerduo commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alanscut Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

miaoerduo Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

Alanscut Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

miaoerduo Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

miaoerduo Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

Alanscut Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

miaoerduo Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

miaoerduo commented Apr 3, 2020 •

edited

Loading