This repository was archived by the owner on Nov 6, 2023. It is now read-only.
separate commit for each file -- re: pull 37#53
Closed
vicgarin wants to merge 185 commits into
Closed
Conversation
Closed
Contributor
|
This doesn't pass the ruleset validation tests. Please run makexpi.sh or makecrx.sh to build a test package and test it. The updated README explains how to do this. Also, a lot of your rulesets should be modifications to existing rulesets rather than new ones (ex: Google). |
Contributor
|
So I'm scared to merge this because it's a huge pull request to review. :/ How did you generate all these rules? |
Contributor
|
it'd be nice if all the commit summaries weren't just "new rules" either... |
Author
|
@diracdeltas @reedy See #78 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate commit for each file -- re: pull 37
#37