183 new rules; put file name in commit comments; removed 1 rule; was pull request 53 & 37#78
183 new rules; put file name in commit comments; removed 1 rule; was pull request 53 & 37#78vicgarin wants to merge 185 commits into
Conversation
|
Thanks for making those requested changes, @vicgarin. To help me feel better about merging this change, can you explain what methodology you used to create and test this big list? We are considering a maintainer / test URL system (https://lists.eff.org/pipermail/https-everywhere/2014-August/002213.html). Would you be willing to be a maintainer for each of these new rulesets, and add representative test URLs? I notice you added a Google.xml ruleset. We already have several rulesets that affect Google domains in various ways. How does your new Google.xml interact with them? |
|
@jsha are you able to pull specific commits? That is only the commits you approve of? Or do you need to pull it all at once? |
|
I could manually pull in specific rulesets, but the most helpful thing would be a description of your rule generation and testing methodology so I can reproduce it. Thanks! |
|
@jsha I used HTTPS Finder |
vicgarin
changed the title
|
I'm just going to close this PR now... There's seemingly quite a lot that needs work, and/or might've been done in the meantime |
3 participants
put file name in commit comments;
deleted Ebay.promotionexpert.xml per comment in pull request #53;
was pull request 53 & 37
please tell me if there are any more files you want me to delete?
and then I will make one final pull request after deleting them.