Skip to content

Switch from deprecated team member API to team memberships API#209

Merged
pilot merged 1 commit into
KnpLabs:masterfrom
skwashd:memberships-api
Dec 22, 2014
Merged

Switch from deprecated team member API to team memberships API#209
pilot merged 1 commit into
KnpLabs:masterfrom
skwashd:memberships-api

Conversation

@skwashd

@skwashd skwashd commented Nov 16, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@skwashd

skwashd commented Nov 16, 2014

Copy link
Copy Markdown
Contributor Author

The old addMember() calls fail if the user isn't an existing member of the organisation. See https://developer.github.com/changes/2014-09-23-one-more-week-before-the-add-team-member-api-breaking-change/ for more info.

I didn't rename the methods so this would be a drop in change.

@skwashd

skwashd commented Nov 16, 2014

Copy link
Copy Markdown
Contributor Author

The travis fail was because the PHP 5.6 test run failed to clone the repo.

@stof

stof commented Dec 1, 2014

Copy link
Copy Markdown
Contributor

@pilot any plan to merge this ?

pilot added a commit that referenced this pull request Dec 22, 2014
Switch from deprecated team member API to team memberships API
@pilot pilot merged commit c4fb5fe into KnpLabs:master Dec 22, 2014
@pilot

pilot commented Dec 22, 2014

Copy link
Copy Markdown
Contributor

ou guys, sorry just note this PR

@skwashd good job!

@stof thanks for mention

@skwashd skwashd deleted the memberships-api branch December 23, 2014 01:42
@skwashd skwashd restored the memberships-api branch December 23, 2014 01:43
@skwashd skwashd deleted the memberships-api branch June 23, 2015 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants