Skip to content

Fix memory leak in sp_lvl:lspo_region#1162

Closed
mkuoppal wants to merge 1 commit into
NetHack:NetHack-3.7from
mkuoppal:leakfix
Closed

Fix memory leak in sp_lvl:lspo_region#1162
mkuoppal wants to merge 1 commit into
NetHack:NetHack-3.7from
mkuoppal:leakfix

Conversation

@mkuoppal

@mkuoppal mkuoppal commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

We have cloned a selection, free it in order
to avoid memory leak.

@mkuoppal mkuoppal force-pushed the leakfix branch 2 times, most recently from 5865388 to ce92752 Compare December 5, 2023 12:40
If tutorial is entered, we get following leak on exit:

=================================================================
==81358==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 96 byte(s) in 3 object(s) allocated from:
    #0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
        NetHack#1 0x5601c255bcbb in alloc /home/miku/src/NetHack/src/alloc.c:71

Indirect leak of 5064 byte(s) in 3 object(s) allocated from:
    #0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
        NetHack#1 0x5601c255be1e in alloc /home/miku/src/NetHack/src/alloc.c:71
	    NetHack#2 0x5601c255be1e in dupstr /home/miku/src/NetHack/src/alloc.c:236

SUMMARY: AddressSanitizer: 5160 byte(s) leaked in 6 allocation(s).

Fix this by freeing the cloned selection before returning.
@mkuoppal

mkuoppal commented Dec 5, 2023

Copy link
Copy Markdown
Contributor Author

sp_lvl: fix memory leak on lspo_region
If tutorial is entered, we get following leak on exit:

=================================================================
==81358==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 96 byte(s) in 3 object(s) allocated from:
#0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x5601c255bcbb in alloc /home/miku/src/NetHack/src/alloc.c:71

Indirect leak of 5064 byte(s) in 3 object(s) allocated from:
#0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x5601c255be1e in alloc /home/miku/src/NetHack/src/alloc.c:71
#2 0x5601c255be1e in dupstr /home/miku/src/NetHack/src/alloc.c:236

SUMMARY: AddressSanitizer: 5160 byte(s) leaked in 6 allocation(s).

Fix this by freeing the cloned selection before returning.

@mkuoppal mkuoppal changed the title sp_lvl: free cloned selection Fix memory leak in sp_lvl:lspo_region Dec 5, 2023
@pat-rankin pat-rankin closed this Jan 7, 2024
@pat-rankin

Copy link
Copy Markdown

This pull request was applied 2023-December-17 by paxed.

nhmall referenced this pull request Jan 7, 2024
If tutorial is entered, we get following leak on exit:

=================================================================
==81358==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 96 byte(s) in 3 object(s) allocated from:
    #0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
        #1 0x5601c255bcbb in alloc /home/miku/src/NetHack/src/alloc.c:71

Indirect leak of 5064 byte(s) in 3 object(s) allocated from:
    #0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
        #1 0x5601c255be1e in alloc /home/miku/src/NetHack/src/alloc.c:71
	    #2 0x5601c255be1e in dupstr /home/miku/src/NetHack/src/alloc.c:236

SUMMARY: AddressSanitizer: 5160 byte(s) leaked in 6 allocation(s).

Fix this by freeing the cloned selection before returning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants