Prioritize highlight of command names, prevent bleed from aligned nested tokens#989
Merged
daxian-dbw merged 3 commits intoSep 6, 2019
Merged
Conversation
reference PowerShell#836, specifically handles parameter token that is flagged as a command name, it is really a command name.
When a nested token ends together with the parent token, the signal would be lost, and the rest of the statement would be highlighted as the parent.
Collaborator
Author
|
I added another commit to complete what can be fixed in #836, where nested tokens would bleed the parent tokens color unto the rest of the statement, if the last nested token ended together with the parent token. In the case of |
msftrncs
changed the title
daxian-dbw
approved these changes
Sep 5, 2019
daxian-dbw
left a comment
daxian-dbw
left a comment
Member
There was a problem hiding this comment.
Could you please add a test? I'm not sure if it's easy to do so though ...
Collaborator
Author
|
I have added a commit that implements two test scenarios, each of which attempts to test for the two items addressed above under slightly different scenarios. |
Add 2 tests to RenderTests, both tests simultaneously check for priority to highlight command names, and check for highlight bleed from expandable token which has a nested token that ends together with the parent token.
msftrncs
force-pushed
the
PrioritizeCommandHighlight
branch
from
2789f32 to
2062ead
Compare
Collaborator
Author
|
I force pushed as my previous commit was trying to change (remove) the BOM. |
This was referenced Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing #836,