Skip to content

Replace string-compare-based test for copying to same file with more … #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 7 commits into from
Apr 21, 2017
Merged

Replace string-compare-based test for copying to same file with more … #3441

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d970809
Replace string-compare-based test for copying to same file with more …
Mar 27, 2017
3263893
Update tests per code review
Apr 18, 2017
a1e905b
Fix Pester test for Windows
Apr 19, 2017
9fff05b
More test changes per code review
Apr 20, 2017
8814054
More changes per code review, and fix Travis CI failure on macOS
Apr 20, 2017
19702a0
Move Windows-only test into separate It block.
Apr 21, 2017
07b1594
Move test body from It block into function.
Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Pester test for Windows
  • Loading branch information
Jeff Bienstadt committed Apr 19, 2017
commit a1e905b9c12138ba775106c9bf9190191a42f706
8 changes: 4 additions & 4 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,9 @@ Describe "Copy-Item can avoid copying an item onto itself" -Tags "CI", "RequireA
}
else
{
Copy-Item -Path $sourcePath -Destination $destinationPath -ErrorAction SilentlyContinue | ShouldBeErrorId "CopyError,Microsoft.PowerShell.Commands.CopyItemCommand"
$_.Exception | Should BeOfType System.IO.IOException
$_.Exception.Data[$selfCopyKey] | Should Not Be $null
{ Copy-Item -Path $sourcePath -Destination $destinationPath -ErrorAction Stop } | ShouldBeErrorId "CopyError,Microsoft.PowerShell.Commands.CopyItemCommand"
$Error[0].Exception | Should BeOfType System.IO.IOException
$Error[0].Exception.Data[$selfCopyKey] | Should Not Be $null
}
}
}
Expand Down Expand Up @@ -806,7 +806,7 @@ Describe "Extended FileSystem Path/Location Cmdlet Provider Tests" -Tags "Featur
$result = Split-Path -Path $level1_0Full -Leaf
$result | Should Be $level1_0
}

@iSazonov iSazonov Apr 17, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It distracts attention. We should make separate PR for formatting.

It 'Validate LeafBase' {
$result = Split-Path -Path "$level2_1Full$fileExt" -LeafBase
$result | Should Be $level2_1
Expand Down