Skip to content

Added comma to replaced characters in assemblyname #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 9 commits into from
Jul 6, 2017
Merged

Added comma to replaced characters in assemblyname #4136

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56c72fb
Added comma to replaced characters in assemblyname
TimCurwick Jun 28, 2017
853ebcc
Added Pester test for Classes runpath
TimCurwick Jun 28, 2017
7eb13b1
Added tags
TimCurwick Jun 28, 2017
0190477
Fixed tags
TimCurwick Jun 28, 2017
5d69d2c
Fixed typo in comments
TimCurwick Jun 28, 2017
c3b823f
Update Scripting.Classes.RunPath.Tests.ps1
TimCurwick Jun 28, 2017
c1a8dd8
Merge pull request #1 from TimCurwick/MStweaks
TimCurwick Jun 28, 2017
3d4cef5
Added tag. Again.
TimCurwick Jun 28, 2017
88c0b9b
Removed redundant test
TimCurwick Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed tags
  • Loading branch information
@TimCurwick
TimCurwick authored Jun 28, 2017
commit 0190477c734e7a788812a945a0c2830e4cc753ca
6 changes: 3 additions & 3 deletions test/powershell/Language/Classes/Scripting.Classes.RunPath.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Describe "Script with a class definition run path" {
Describe "Script with a class definition run path" -Tags "CI" {

It "Script with a class definition can run from a path without a comma" -Tags "CI" {
It "Script with a class definition can run from a path without a comma" {

$FilePath = '.\MyTest.ps1'

@adityapatwardhan adityapatwardhan Jun 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use $TestDrive for temporary files.


Expand All @@ -20,7 +20,7 @@ Describe "Script with a class definition run path" {
$Success | Should Be $True

@lzybkr lzybkr Jun 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid Should Be $True - this results in a typically unhelpful message in the log.

I suggest a test that actually uses the class, so maybe something like:

Instead, try something like:

`@
class MyClass { static [string]$MyProperty = $PSScriptRoot }
[MyClass]::MyProperty
'@ > $testDrive/My,Test.ps1

& $testDrive/My,Test.ps1 | Should Match ".*My,Test.ps1"

Or something like that.

@TimCurwick TimCurwick Jun 28, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PSScriptRoot doesn't work inside a class.

}

It "Script with a class definition can run from a path with a comma" -Tags "CI" {
It "Script with a class definition can run from a path with a comma" {

@adityapatwardhan adityapatwardhan Jun 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as above test

@adityapatwardhan adityapatwardhan Jun 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two test cases can be combined into 1 using the -TestCases parameter for It. Example:

PowerShell/test/powershell/Language/Parser/LanguageAndParser.TestFollowup.Tests.ps1

Line 147 in 02b5f35

$testCase = @(


$FilePath = '.\My,Test.ps1'

Expand Down