Skip to content

Fix Start-PSPester support for running tests w/ sudo #6241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 4 commits into from
Feb 27, 2018
Merged

Fix Start-PSPester support for running tests w/ sudo #6241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e92855
[feature]
SteveL-MSFT Feb 26, 2018
3a5fbc6
[feature]
SteveL-MSFT Feb 26, 2018
2a66001
[feature]
SteveL-MSFT Feb 26, 2018
00c746b
revert changes in set-date.tests.ps1 and travis.ps1
SteveL-MSFT Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[feature] 
address Travis' feedback
  • Loading branch information
@SteveL-MSFT
SteveL-MSFT committed Feb 27, 2018
commit 2a66001045ab8cbdf0eddf3d9b6c4eb8952ed345
6 changes: 3 additions & 3 deletions build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ function Get-PesterTag {
}
$values = $vAst.FindAll({$args[0] -is "System.Management.Automation.Language.StringConstantExpressionAst"},$true).Value
$values | ForEach-Object {
if (@('REQUIREADMINONWINDOWS', 'REQUIRESUDOONUNIX', 'SLOW', 'REQUIRENOSUDOONUNIX') -contains $_) {
if (@('REQUIREADMINONWINDOWS', 'REQUIRESUDOONUNIX', 'SLOW') -contains $_) {
# These are valid tags also, but they are not the priority tags
}
elseif (@('CI', 'FEATURE', 'SCENARIO') -contains $_) {
Expand Down Expand Up @@ -1034,9 +1034,9 @@ Restore the module to '$Pester' by running:
}
elseif (-not $Environment.IsWindows -and $Sudo.IsPresent)
{
if (-not $PSBoundParameters.ContainsKey('ExcludeTag'))
if (-not $PSBoundParameters.ContainsKey('Tag'))
{
$ExcludeTag += 'RequireNoSudoOnUnix'
$Tag = 'RequireSudoOnUnix'
}
}

Expand Down
2 changes: 1 addition & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Date.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Describe "Set-Date for admin" -Tag @('CI', 'RequireAdminOnWindows', 'RequireSudo
}
}

Describe "Set-Date" -Tag @('CI', 'RequireNoSudoOnUnix') {
Describe "Set-Date" -Tag @('CI') {
It "Set-Date should produce an error in a non-elevated context" {
{ Get-Date | Set-Date } | ShouldBeErrorId "System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.SetDateCommand"
}
Expand Down