Update `test_grammar.py` to 3.14.5 by ShaharNaveh · Pull Request #7913 · RustPython/RustPython

ShaharNaveh · 2026-05-18T13:41:18Z

Summary by CodeRabbit

Bug Fixes
- Improved error messages for syntax validation and parsing errors
- Enhanced error reporting for loop control statements and additional edge cases in validation
- Updated feedback text for better clarity on invalid syntax

coderabbitai · 2026-05-18T13:41:26Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 58e849ed-fc1c-4d26-b482-9aea6af87f43

📥 Commits

Reviewing files that changed from the base of the PR and between e8d7437 and d332789.

⛔ Files ignored due to path filters (2)

Lib/test/test_grammar.py is excluded by !Lib/**
Lib/test/test_syntax.py is excluded by !Lib/**

📒 Files selected for processing (3)

crates/codegen/src/compile.rs
crates/codegen/src/error.rs
crates/vm/src/vm/vm_new.rs

💤 Files with no reviewable changes (1)

crates/codegen/src/compile.rs

📝 Walkthrough

Walkthrough

This PR refines error handling in the RustPython compiler by updating error message text, expanding parse error to syntax error mapping with four new cases, and removing overly strict validation for exception type syntax.

Changes

Error Handling and Validation Refinements

Layer / File(s)	Summary
Error message improvements `crates/codegen/src/error.rs`	The `Display` impl for `CodegenErrorType` is refactored to use explicit `Self::` patterns instead of glob imports. The `InvalidContinue` error message is updated to "'continue' not properly in loop" from "'continue' outside loop".
Extended parse error to syntax error mapping `crates/vm/src/vm/vm_new.rs`	The `new_syntax_error_maybe_incomplete` function adds support for `EmptyTypeParams`, `InvalidStarPatternUsage` (with narrow caret enabled), `ExpectedKeywordParam`, and `EmptyImportNames` parse error variants. The `OtherError` handler now also recognizes and maps "positional patterns cannot follow keyword patterns" messages.
Relaxed exception type validation `crates/codegen/src/compile.rs`	The compiler removes the syntax check that rejected unparenthesized tuple exception types, allowing exception type expressions to compile without that guard.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

youknowone

Poem

🐰 When errors dance and messages sing,
We polish each word, refine the ring,
Remove the guards that were too tight,
Map new patterns into light! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title claims to update test_grammar.py to 3.14.5, but the actual changes are in compiler and VM code (compile.rs, error.rs, vm_new.rs) with no modifications to test_grammar.py.	Revise the title to accurately reflect the actual changes, such as 'Remove unparenthesized tuple exception type syntax check and improve error messages' or 'Update compiler syntax validation and error handling'.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-18T13:42:16Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_grammar.py (TODO: 12)

dependencies:

dependent tests: (no tests depend on grammar)

[ ] test: cpython/Lib/test/test_syntax.py (TODO: 356)

dependencies:

dependent tests: (no tests depend on syntax)

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

ShaharNaveh · 2026-05-19T10:27:29Z

+                }
+                else if s.eq_ignore_ascii_case("positional patterns cannot follow keyword patterns") {
+                    msg = "positional patterns follow keyword patterns".to_owned();
+                }


I'd wish to extract this entire match block to its own function, I'll do it as a followup PR.

Update test_grammar.py to 3.14.5

e3bfe69

ShaharNaveh added 11 commits May 19, 2026 09:44

Merge remote-tracking branch 'upstream/main' into update-test-grammar

bffa7b0

Fix failing test

1c87ddd

Update test_syntax.py to 3.14.5

c050108

Some patches and fixes

d6061e6

more markers

00e3d2b

More

8267b2a

Done doctest patches

34757b5

More markers

ee6b987

Fix continue error message

3b61bde

Merge remote-tracking branch 'upstream/main' into update-test-grammar

7c4e30c

Fix accedental deletion

d332789

ShaharNaveh marked this pull request as ready for review May 19, 2026 10:26

ShaharNaveh commented May 19, 2026

View reviewed changes

ShaharNaveh requested a review from youknowone May 19, 2026 11:09

youknowone approved these changes May 19, 2026

View reviewed changes

youknowone merged commit 0a2461a into RustPython:main May 19, 2026
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `test_grammar.py` to 3.14.5#7913

Update `test_grammar.py` to 3.14.5#7913
youknowone merged 12 commits into
RustPython:mainfrom
ShaharNaveh:update-test-grammar

ShaharNaveh commented May 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 18, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

github-actions Bot commented May 18, 2026 •

edited

Loading

Uh oh!

ShaharNaveh May 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ShaharNaveh commented May 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

github-actions Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

ShaharNaveh May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented May 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 18, 2026 •

edited

Loading

github-actions Bot commented May 18, 2026 •

edited

Loading

ShaharNaveh May 19, 2026 •

edited

Loading