feat(types): nested refs + numerical_id#6
Closed
Mlaz-code wants to merge 1 commit into
Closed
Conversation
Add structured ref types (TeamRef, SportRef, EntityRef, NestedRefs) plus Team and Market reference types, then surface optional home/away/ sport_ref/league_ref/market_ref/sportsbook_ref on every odds, opportunity, and reference row shipping in api-adapters PR #489 + sharp-api-go PR #345. Reference endpoints (Sport, League, Sportsbook, Market) gain optional numerical_id, and Team adds optional abbreviation. ArbitrageLeg gains sportsbook_ref, ClosingOdd gains market_ref + sportsbook_ref. All fields are additive — legacy code keeps compiling. LowHoldOpportunity is upgraded from untyped to a proper interface so nested refs surface alongside the flat fields; the [key: string] index signature preserves forward compatibility. Bumps to 0.3.0 (minor — purely additive, no field renames or removals). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Mlaz-code
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional TypeScript types for new nested reference fields. All additions are non-breaking.
What changes
TeamRef,SportRef,EntityRef,Team,Market,NestedRefsbundleLowHoldOpportunity(was loosely typed before)NormalizedOdds,EVOpportunity,ArbitrageOpportunity,MiddleOpportunityextend with optional nested refs viaNestedRefsArbitrageLeggainssportsbook_ref;ClosingOddsLine/ClosingOddgainmarket_ref+sportsbook_refSport,League,Sportsbook,Market) gainnumerical_id;Teamaddsabbreviation+numerical_idVersion bump
0.2.9 → 0.3.0— minor bump (additive only).