Issue 4906: Preserve windows error state across PyThread_get_key_value

kristjan.jonsson · kristjan.jonsson · commit 40b476503824 · 2009-01-10T12:14:31.000Z
git-svn-id: http://svn.python.org/projects/python/trunk@68476 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Python/thread_nt.h b/Python/thread_nt.h
@@ -315,7 +315,16 @@ PyThread_set_key_value(int key, void *value)
 void *
 PyThread_get_key_value(int key)
 {
-	return TlsGetValue(key);
+	/* because TLS is used in the Py_END_ALLOW_THREAD macro,
+	 * it is necessary to preserve the windows error state, because
+	 * it is assumed to be preserved across the call to the macro.
+	 * Ideally, the macro should be fixed, but it is simpler to
+	 * do it here.
+	 */
+	DWORD error = GetLastError();
+	void *result = TlsGetValue(key);
+	SetLastError(error);
+	return result;
 }
 
 void
