Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getpatchwork/patchwork
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: ajdlinux/patchwork
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 20, 2017

  1. WIP fix comment return 

    Signed-off-by: Andrew Donnellan <[email protected]>
    @ajdlinux
    ajdlinux committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    5a301b9 View commit details
    Browse the repository at this point in the history

  2. WIP add more error messages to parse_mail 

    Signed-off-by: Andrew Donnellan <[email protected]>
    @ajdlinux
    ajdlinux committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    48cde67 View commit details
    Browse the repository at this point in the history

  3. models: Fix invocation of refresh_tag_counts() for Comments 

    In Comment.save() and Comment.delete(), we always call
Submission.refresh_tag_counts(), which is an empty stub, rather than
calling Patch.refresh_tag_counts() if the Submission is a Patch.

As such, tag counts are never updated on incoming comments.

Delete Submission.refresh_tag_counts(), as it's useless, and in
Comment.save()/delete(), invoke Patch.refresh_tag_counts() directly when
the submission is a Patch.

Reported-by: David Demelier <[email protected]>
Fixes: 86172cc ("models: Split Patch into two models")
Closes-bug: #111 ("A/R/T not updated on comments")
Signed-off-by: Andrew Donnellan <[email protected]>
    @ajdlinux
    ajdlinux committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    585199a View commit details
    Browse the repository at this point in the history

  4. tests: Add test for updating tag counts in patch comments 

    We accidentally broke the updating of tag counts for tags in comments, and
we didn't notice for quite a while.

Add a test for this.

Signed-off-by: Andrew Donnellan <[email protected]>
    @ajdlinux
    ajdlinux committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    cf8de94 View commit details
    Browse the repository at this point in the history
Loading