fix: recover component lifecycle and avoid execute from scope __proto__

1ncounter · liujuping · commit 394b56d0cef7 · 2023-11-22T21:16:10.000+08:00
diff --git a/packages/renderer-core/src/renderer/base.tsx b/packages/renderer-core/src/renderer/base.tsx
@@ -50,6 +50,11 @@ export function executeLifeCycleMethod(context: any, schema: IPublicTypeNodeSche
     return;
   }
 
+  // avoid execute lifeCycle method from __proto__'s method (it is React class Component Class lifeCycle)
+  if (!Object.prototype.hasOwnProperty.call(context, method) && method !== 'constructor') {
+    return;
+  }
+
   // TODO: cache
   if (isJSExpression(fn) || isJSFunction(fn)) {
     fn = thisRequiredInJSE ? parseThisRequiredExpression(fn, context) : parseExpression(fn, context);
diff --git a/packages/renderer-core/src/renderer/component.tsx b/packages/renderer-core/src/renderer/component.tsx
@@ -46,26 +46,5 @@ export default function componentRendererFactory(): IBaseRenderComponent {
 
       return this.__renderComp(Component, this.__renderContextProvider({ compContext: this }));
     }
-
-    getComponentName() {
-      return this.props?.componentName;
-    }
-
-    /** &#38656;&#35201;&#37325;&#36733;&#19979;&#38754;&#20960;&#20010;&#26041;&#27861;&#65292;&#22914;&#26524;&#22312;&#20302;&#20195;&#30721;&#32452;&#20214;&#20013;&#32465;&#23450;&#20102;&#23545;&#24212;&#30340;&#29983;&#21629;&#21608;&#26399;&#26102;&#20250;&#20986;&#29616;&#27515;&#24490;&#29615; */
-    componentDidMount() {
-      this.__debug(`componentDidMount - ${this.getComponentName()}`);
-    }
-    getSnapshotBeforeUpdate() {
-      this.__debug(`getSnapshotBeforeUpdate - ${this.getComponentName()}`);
-    }
-    componentDidUpdate() {
-      this.__debug(`componentDidUpdate - ${this.getComponentName()}`);
-    }
-    componentWillUnmount() {
-      this.__debug(`componentWillUnmount - ${this.getComponentName()}`);
-    }
-    componentDidCatch() {
-      this.__debug(`componentDidCatch - ${this.getComponentName()}`);
-    }
   };
 }
