fix: executeLifeCycleMethod return bug in renderer#2705
Merged
Conversation
Collaborator
|
@owenchen1004 有一条关于代码风格的建议，建议使用 if 判断，而不是 || 运算符，这样逻辑表述比表达式更加的清晰明了 |
Contributor
Author
感谢指点，换了三元表达式，逻辑上更清晰了 |
Collaborator
|
1.2.3-beta.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix：#2704
在getDerivedStateFromProps()加了一个undefined校验，没有直接改executeLifeCycleMethod()，以免影响其他方法。