Skip to content

Commit 56d5809

Browse files
committed
Updated Halim's object compare
1 parent 86b6c1c commit 56d5809

1 file changed

Lines changed: 3 additions & 11 deletions

File tree

Week4/equal.js

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict';
2-
31
const obj1 = {
42
a: '1',
53
b: 'this is the letter b',
@@ -29,21 +27,15 @@ function equal(a, b, mode) {
2927
typeof b == 'object' &&
3028
Object.keys(a).length == Object.keys(b).length) {
3129

32-
const keys = Object.keys(a);
33-
for (const key of keys) {
34-
if (b.hasOwnProperty(key)) {
35-
const aValue = a[key];
36-
const bValue = b[key];
37-
if (!equal(aValue, bValue, mode)) {
38-
return false;
39-
}
40-
} else {
30+
for (const key of Object.keys(a)) {
31+
if (!b.hasOwnProperty(key) || !equal(a[key], b[key], mode)) {
4132
return false;
4233
}
4334
}
4435

4536
return true;
4637
}
38+
4739
return false;
4840
};
4941

0 commit comments

Comments
 (0)