Quick Fix for issues arising with step size in sequences > 1#1847
Merged
Conversation
umar456
requested changes
Jun 21, 2017
umar456
left a comment
umar456
left a comment
Member
There was a problem hiding this comment.
Looks good. 👍 Minor changes requested.
| ASSERT_EQ(af::allTrue<bool>(c == d), true); | ||
| } | ||
|
|
||
| TEST(Index, ISSUE_184_Index_Step_reorder) |
| dim4 parent_strides = parent.strides(); | ||
|
|
||
| if (dStrides != parent_strides) { | ||
| const Array<T> &parentCopy = copyArray(parent); |
Member
There was a problem hiding this comment.
copyArray returns an Array by value. I would just make this a value Array rather than a reference array. The createSubArray function should increase the reference count anyway. It would be a good idea to check.
| af::array b = a(span, af::seq(0, af::end, 2)); | ||
| af::array c = b(span, af::seq(0, af::end, 3)); | ||
| af::array d = a(span, af::seq(0, af::end, 6)); | ||
| ASSERT_EQ(af::allTrue<bool>(c == d), true); |
Member
There was a problem hiding this comment.
EXPECT_TRUE(af::allTrue<bool>(c == d));
| array a = af::randu(1,8,1); | ||
| array b = reorder(a,0,2,1); | ||
| array d = reorder(b(0,0,span),2,1,0); | ||
| ASSERT_EQ(af::allTrue<bool>(a.T() == d), true); |
Member
There was a problem hiding this comment.
EXPECT_TRUE(af::allTrue<bool>(a.T() == d));
| { | ||
| using namespace af; | ||
| af::array a = af::randu(3, 12); | ||
| af::array b = a(span, af::seq(0, af::end, 2)); |
- Added relevant tests - Updated release notes
umar456
approved these changes
Jun 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added relevant tests
Updated release notes
Fixes Bug in Indexing an already indexed array #1846
Fixes Bug in indexing after reorder #1845