Skip to content

Write array patch #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9prady9 merged 2 commits into from
May 6, 2021
Merged

Write array patch #3130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcdae7d
Add shortcut check for zero elements in af_write_array
avidov Dec 14, 2020
04a90f1
Add missing input checks in af_write_array
Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/api/c/array.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,12 @@ void write_array(af_array arr, const T *const data, const size_t bytes,

af_err af_write_array(af_array arr, const void *data, const size_t bytes,
af_source src) {
if (bytes == 0) { return AF_SUCCESS; }
try {
af_dtype type = getInfo(arr).getType();
ARG_ASSERT(1, (data != nullptr));
ARG_ASSERT(3, (src == afHost || src == afDevice));
// FIXME ArrayInfo class no bytes method, hence commented
// DIM_ASSERT(2, bytes <= getInfo(arr).bytes());

switch (type) {
Expand Down