fix(coderd/taskname): parse task name JSON with trailing text#25005
Merged
Conversation
github-actions
Bot
added
the
community
johnstcn
approved these changes
May 7, 2026
Comment on lines
106
to
116
| // Only strip when there is a newline separating the fence line | ||
| // from the body. Without one we cannot reliably tell the fence | ||
| // from the content. | ||
| if idx := strings.Index(s, "\n"); idx != -1 { | ||
| s = s[idx+1:] | ||
| s = strings.TrimSuffix(s, "```") | ||
| if fenceIdx := strings.Index(s, "\n```"); fenceIdx != -1 { | ||
| s = s[:fenceIdx] | ||
| } else { | ||
| s = strings.TrimSuffix(s, "```") | ||
| } | ||
| s = strings.TrimSpace(s) |
Member
There was a problem hiding this comment.
Is this one of the rare situations where a regex would be conceptually simpler? :)
Member
|
Smoke-tested on dogfood ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthropic task name responses can include valid JSON followed by a closing fence or extra text, which made
json.Unmarshalfail with trailing-character errors and forced fallback naming.This updates task name JSON extraction to accept the first JSON value after optional fences and adds regression coverage for fenced and bare JSON with trailing content.