chore(security): patch pnpm audit vulnerabilities via overrides#390
Closed
jamesbhobbs wants to merge 2 commits into
Closed
chore(security): patch pnpm audit vulnerabilities via overrides#390jamesbhobbs wants to merge 2 commits into
jamesbhobbs wants to merge 2 commits into
Conversation
Resolve all pnpm audit findings: - vitest 4.0.5 -> 4.1.8 (critical: arbitrary file read/exec via Vitest UI server, GHSA-5xrq-8626-4rwp); bump @vitest/coverage-v8 to match - brace-expansion override >=5.0.5 -> >=5.0.6 (moderate DoS, GHSA-jxxr-4gwj-5jf2) - add ws override >=8.20.1 (moderate uninitialized memory disclosure, GHSA-58qx-3vcg-4xpx) - add qs override >=6.15.2 (moderate DoS in qs.stringify, GHSA-q8mj-m7cp-5q26) Also patch 6 pre-existing audit findings surfaced on main that share the same transitive-override pattern: - add fast-uri override >=3.1.2 (high: path traversal + host confusion) - bump hono override >=4.12.14 -> >=4.12.18 (CSS injection, cache Vary, JWT NumericDate) - add ip-address override >=10.1.1 (moderate XSS in Address6) pnpm audit now reports no known vulnerabilities. Full test suite (2200 tests) passes on vitest 4.1.8. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches⚔️ Resolve merge conflicts
Comment |
…st-ws-qs-brace-expansion # Conflicts: # pnpm-lock.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 145 145
Lines 7988 7988
Branches 2158 2220 +62
=======================================
Hits 6658 6658
Misses 1329 1329
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all
pnpm auditfindings.pnpm auditnow reports no known vulnerabilities (exit 0), and the full test suite (2200 tests across 127 files) passes on the new vitest.Requested fixes (from the reported audit)
vitest4.0.5→4.1.8(+@vitest/coverage-v8to match)brace-expansion>=5.0.5→>=5.0.6ws>=8.20.1qs>=6.15.2qs.stringifyAdditional pre-existing findings also patched
While fixing the above I found that
pnpm auditonmainalso reports 6 more vulnerabilities (2 high) inhono/fast-uri/ip-address— the same set the never-merged draft #376 targeted. Patched here too so the audit is fully clean (same transitive-override pattern):fast-uri>=3.1.2(path traversal + host confusion)hono>=4.12.14→>=4.12.18(CSS injection, cacheVary, JWT NumericDate)ip-address>=10.1.1(XSS inAddress6)This supersedes draft #376 — it can be closed.
Verification
pnpm audit→No known vulnerabilities found(exit 0)pnpm test→ 2200 passed (127 files) on vitest 4.1.8Note
Root
pnpm.overridesonly protect monorepo/CI installs — they do not ship with the published@deepnote/mcppackage. End-user@deepnote/mcpinstalls still resolveip-addressviaexpress-rate-limit's exact pin until that's fixed upstream.🤖 Generated with Claude Code
Summary by CodeRabbit