Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-cloud-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: dimroc/google-cloud-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Sep 25, 2017

  1. Update GCS file signing to not crash with symbols 

    Rails 5.2 ActiveStorage will, by default, pass symbols as values for the
query parameter, as shown with this default `:inline` parameter:

https://github.com/rails/rails/blob/master/activestorage/app/models/active_storage/variant.rb#L64

Before this commit, this would result in the error:

`TypeError: no implicit conversion of Symbol into String`
    @dimroc @blowmage
    dimroc authored and blowmage committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    0537fbe View commit details
    Browse the repository at this point in the history
Loading