fix: Changing Snowflake template code to avoid query not implemented error…#3315
fix: Changing Snowflake template code to avoid query not implemented error…#3315amithadiraju1694 wants to merge 0 commit into
Conversation
|
/assign @woop |
amithadiraju1694
changed the title
|
/ok-to-test |
Codecov ReportBase: 67.65% // Head: 57.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3315 +/- ##
==========================================
- Coverage 67.65% 57.87% -9.79%
==========================================
Files 181 215 +34
Lines 16645 18092 +1447
==========================================
- Hits 11262 10471 -791
- Misses 5383 7621 +2238
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amithadiraju1694 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
See #3319 |
Thanks for update @sfc-gh-madkins new to contributions, want to fix mistakes on this one. Wondering why this PR was closed and you had to create another one referencing this, is it because I haven't submitted test reports on my PR ? Appreciate the guidance, Thanks again ! |
5 participants
Signed-off-by: amithadiraju1694 [email protected]
What this PR does / why we need it:
The Snowflake template code has some bugs when implementing sql query to fetch data from snowflake.
store.list_data_sources()[-1]selects aRequestSourceobject rather thanSnowflakeSourceobject; obviously request source object doesn't implementget_table_query_string()throwingNotImplementedError.Changing
store.list_data_sources()[-1]tostore.get_data_source('table_name_of_source')solves the issue and is more reliable way of executing the query on the source.Which issue(s) this PR fixes:
Fixes #3301