Skip to content

fix: Auto-detect GCS/S3 registry store when registry is passed as string#6260

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
jiwidi:fix/gcs-registry-string-detection
Apr 14, 2026
Merged

fix: Auto-detect GCS/S3 registry store when registry is passed as string#6260
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
jiwidi:fix/gcs-registry-string-detection

Conversation

@jiwidi
Copy link
Copy Markdown
Contributor

@jiwidi jiwidi commented Apr 11, 2026 •
edited by devin-ai-integration Bot
Loading

Problem

When passing registry="gs://bucket/feast/registry.pb" as a string to RepoConfig, Feast always creates a file-based RegistryConfig (hardcoded at repo_config.py line ~402). This ignores the URI scheme and causes FileRegistryStore to be used, which cannot handle gs:// paths — pathlib.Path("gs://...") is not treated as absolute, leading to IsADirectoryError at runtime.

The RegistryConfig docstring states:

If registry_type is 'file', then can be a local path, or remote object storage path, e.g. a GCS URI

But FileRegistryStore uses pathlib.Path which doesn't support GCS URIs.

Meanwhile, Registry.__init__ already has correct scheme-based auto-detection via get_registry_store_class_from_scheme() and REGISTRY_STORE_CLASS_FOR_SCHEME = {"gs": "GCSRegistryStore", ...} — it just never gets a chance because the RegistryConfig is pre-wrapped as "file" type.

Root Cause

In RepoConfig.registry property, the elif isinstance(self.registry_config, str) branch hardcodes:

self._registry = get_registry_config_from_type("file")(path=self.registry_config)

This wraps the path in a file-type config regardless of the URI scheme.

Reproduction

from feast.repo_config import RepoConfig

config = RepoConfig(
    project="test",
    provider="gcp",
    registry="gs://my-bucket/feast/registry.pb",
    online_store={"type": "redis", "connection_string": "localhost:6379"},
    entity_key_serialization_version=3,
)
# Before fix: config.registry.registry_store_type is implicitly "file"
#   -> FileRegistryStore -> Path("gs://...").is_absolute() == False
#   -> joins with repo_path -> IsADirectoryError
# After fix: config.registry.registry_store_type is None
#   -> Registry.__init__ auto-detects GCSRegistryStore from scheme

Fix

In RepoConfig.registry property, when registry is a string, create a plain RegistryConfig(path=...) instead of hardcoding get_registry_config_from_type("file"). This preserves registry_store_type=None, letting the existing auto-detection in Registry.__init__ select the correct store class based on the URI scheme.

Local file paths continue to work because registry_type defaults to "file" in RegistryConfig, and get_registry_store_class_from_scheme maps the file scheme (and schemeless paths) to FileRegistryStore.

Tests

Added test_registry_string_config.py with 11 tests covering:

  • GCS/S3/local string registry → correct RegistryConfig with registry_store_type=None
  • Dict registry (existing behavior preserved)
  • REGISTRY_STORE_CLASS_FOR_SCHEME maps gs→GCS, s3→S3, file→File
  • Unknown schemes raise
  • pathlib.Path cannot handle cloud URIs (documenting the underlying issue)
Open with Devin

@jiwidi jiwidi requested a review from a team as a code owner April 11, 2026 12:21
@jiwidi jiwidi force-pushed the fix/gcs-registry-string-detection branch 3 times, most recently from 4ee48c2 to 189f67c Compare April 14, 2026 08:28
@jiwidi jiwidi changed the title fix: auto-detect GCS/S3 registry store when registry is passed as string fix: Auto-detect GCS/S3 registry store when registry is passed as string Apr 14, 2026
@ntkathole ntkathole force-pushed the fix/gcs-registry-string-detection branch from 189f67c to 944e9c2 Compare April 14, 2026 15:42
@franciscojavierarceo franciscojavierarceo merged commit 7ebcf03 into feast-dev:master Apr 14, 2026
27 checks passed
franciscojavierarceo pushed a commit that referenced this pull request May 4, 2026
@feast-ci-bot
chore(release): release 0.63.0
50ad181 
# [0.63.0](v0.62.0...v0.63.0) (2026-05-04)

### Bug Fixes

* Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4))
* Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208)
* Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556))
* Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984))
* Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03))
* **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200)
* correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7))
* disable Redis RDB persistence in test deployments ([44cd682](44cd682))
* Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98))
* Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9))
* Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b))
* Fix issue with apply feature view ([835cda8](835cda8))
* Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d))
* Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a))
* Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356))
* **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a))
* Include git in feast server image ([fb03c46](fb03c46))
* Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c))
* Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77))
* Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd))
* Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43))
* Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e))
* **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf))
* **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d))
* Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e))
* support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889))
* Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55))

### Features

* Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3))
* Add feature view versioning support to FAISS online store ([b36acb7](b36acb7))
* Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163)
* Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105))
* Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157))
* Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0))
* Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738))
* Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced))
* Addresses performance issues in the Redis online store ([2e50da0](2e50da0))
* Allow to set gpu for ray ([5580ab4](5580ab4))
* Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180))
* Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd))
* Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf))
* Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056))
* MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7))
* Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8))
* Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8))
* **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

@ntkathole ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiwidi @franciscojavierarceo @ntkathole