Skip to content

Fix overlay bug when offline#3537

Merged
wu-hui merged 5 commits into
masterfrom
wuandy/OverlayOfflineFix
Mar 16, 2022
Merged

Fix overlay bug when offline#3537
wu-hui merged 5 commits into
masterfrom
wuandy/OverlayOfflineFix

Conversation

@wu-hui
Copy link
Copy Markdown
Contributor

@wu-hui wu-hui commented Mar 15, 2022

Fix: #3528

@wu-hui wu-hui requested a review from dconeybe March 15, 2022 20:10
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Mar 15, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.63% (f5845b2) to 45.66% (834eec2) by +0.03%.

    FilenameBase (f5845b2)Merge (834eec2)Diff
    AsyncQueue.java77.11%78.11%+1.00%
    LocalStore.java99.35%99.37%+0.02%
    MutationBatch.java89.06%89.23%+0.17%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

Notes

  • Commit (834eec2) is created by Prow via merging PR base commit (f5845b2) and head commit (0ff7ae7).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/D4i3gvE32s.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Mar 15, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (f5845b2)Merge (834eec2)Diff
    aar1.24 MB1.24 MB+333 B (+0.0%)
    apk (release)3.38 MB3.38 MB-272 B (-0.0%)

Test Logs

Notes

  • Commit (834eec2) is created by Prow via merging PR base commit (f5845b2) and head commit (0ff7ae7).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TsujZH8Sqk.html

dconeybe
dconeybe requested changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a change log entry. Also, please apply the feedback from @schmidt-sebastian, if any.

@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Mar 15, 2022
wu-hui added 2 commits March 15, 2022 16:40
@wu-hui
Simpler fix
910748d
@wu-hui
Merge branch 'master' into wuandy/OverlayOfflineFix
18e361d 
# Conflicts:
#	firebase-firestore/CHANGELOG.md
schmidt-sebastian
schmidt-sebastian approved these changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread firebase-firestore/CHANGELOG.md Outdated
Comment thread firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
Comment thread firebase-firestore/src/main/java/com/google/firebase/firestore/model/mutation/Mutation.java Outdated
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Mar 15, 2022

@wu-hui: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 0ff7ae7 link /test smoke-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wu-hui
Copy link
Copy Markdown
Contributor Author

wu-hui commented Mar 15, 2022

This PR needs a change log entry. Also, please apply the feedback from @schmidt-sebastian, if any.

Done.

@wu-hui wu-hui merged commit df21954 into master Mar 16, 2022
@wu-hui wu-hui deleted the wuandy/OverlayOfflineFix branch March 16, 2022 00:48
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

+1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wu-hui wu-hui

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cloud_firestore] Snapshot lost all attributes data after offline updates

4 participants

@wu-hui @google-oss-bot @schmidt-sebastian @dconeybe