Skip to content
This repository was archived by the owner on Apr 17, 2021. It is now read-only.

Fix integration test & more user_id clean-up#56

Merged
floscha merged 4 commits into
floscha:masterfrom
marccarre:issues/55-more-user-id-cleanup
Mar 17, 2019
Merged

Fix integration test & more user_id clean-up#56
floscha merged 4 commits into
floscha:masterfrom
marccarre:issues/55-more-user-id-cleanup

Conversation

@marccarre

Copy link
Copy Markdown
Contributor

Follows up on #53. Fixes #55.

Fixes integration tests, previously failing with::
```
>       updated_deck = self.get_deck(deck.id, deck.user_id)
E       AttributeError: 'Deck' object has no attribute 'user_id'

tinycards/networking/rest_api.py:277: AttributeError
```
@floscha

floscha commented Mar 17, 2019

Copy link
Copy Markdown
Owner

Looks like a missed a few user_id instances when creating #53. Thanks for fixing those. When looking closer, I realized there are a few more cases where user_id is used in pointless ways 🙈 However, I'll solve this matter in a later PR and merge this one, to fix #55 and enable rebasing #57.

@floscha floscha merged commit 4aeed73 into floscha:master Mar 17, 2019
@marccarre marccarre deleted the issues/55-more-user-id-cleanup branch March 17, 2019 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants