fix(config): Enable lfs cleanup #37671#37673
Draft
pandareen wants to merge 1 commit into
Draft
Conversation
GiteaBot
added
the
lgtm/need 2
pandareen
changed the title
Contributor
|
This one should be fixed first: -> gitea doctor check --all --fix deleted all my LFS files and attachments #36227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
gc_lfscron task is only registered when LFS is enabled, but it defaulted toEnabled: false, so LFS orphan cleanup never ran unless an admin enabled it.NumberToCheckPerRepoandProportionToCheckPerRepowere defined onGCLFSConfigbut were not passed intoGarbageCollectLFSMetaObjectsOptions, so the intended per-repo sampling limits had no effect.Changes
gc_lfsBaseConfig.Enabledtotrueso scheduled LFS meta-object GC runs by default when the LFS server is on.NumberToCheckPerRepoandProportionToCheckPerRepofrom the cron config intorepository.GarbageCollectLFSMetaObjects.Notes
git gcstill does not remove LFS blobs;gc_lfsremains the mechanism that removes orphanedlfs_meta_objectrows and storage entries after pointer blobs are gone from git.Fixes: #37671
Using AI Opus 4.7