fix(storage): retry errors from last recv on uploads#9616
Conversation
product-auto-label
Bot
added
the
api: storage
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
Overall looks good. Do you feel like our existing test coverage is sufficient for this? If some of these error/continue cases are not hit by our conformance tests, we should talk about adding those.
|
|
||
| // Send a request with as many bytes as possible. | ||
| // Loop until all bytes are sent. | ||
| sendBytes: |
There was a problem hiding this comment.
This is cool but I've literally never seen this in Go code before. Can you add a clarifying comment? It's just pretty rare syntax.
This is caught by our conformance tests, but they are currently skipped. Once the support in the testbench for retrying bidi writes is merged we can remove the skip and it would catch this. |
Update: retry support for bidi writes just merged and is in the v0.43.0 testbench release |
🤖 I have created a release *beep* *boop* --- ## [1.40.0](https://togithub.com/googleapis/google-cloud-go/compare/storage/v1.39.1...storage/v1.40.0) (2024-03-29) ### Features * **storage:** Implement io.WriterTo in Reader ([#9659](https://togithub.com/googleapis/google-cloud-go/issues/9659)) ([8264a96](https://togithub.com/googleapis/google-cloud-go/commit/8264a962d1c21d52e8fca50af064c5535c3708d3)) * **storage:** New storage control client ([#9631](https://togithub.com/googleapis/google-cloud-go/issues/9631)) ([1f4d279](https://togithub.com/googleapis/google-cloud-go/commit/1f4d27957743878976d6b4549cc02a5bb894d330)) ### Bug Fixes * **storage:** Retry errors from last recv on uploads ([#9616](https://togithub.com/googleapis/google-cloud-go/issues/9616)) ([b6574aa](https://togithub.com/googleapis/google-cloud-go/commit/b6574aa42ebad0532c2749b6ece879b932f95cb9)) * **storage:** Update protobuf dep to v1.33.0 ([30b038d](https://togithub.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a)) ### Performance Improvements * **storage:** Remove protobuf's copy of data on unmarshalling ([#9526](https://togithub.com/googleapis/google-cloud-go/issues/9526)) ([81281c0](https://togithub.com/googleapis/google-cloud-go/commit/81281c04e503fd83301baf88cc352c77f5d476ca)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
3 participants
Missed this case when switching to bidi streams