feat(bigquery): Add new fields to JobStatistics#11607
Conversation
Add ReservationId, TotalSlotMs, FinalExecutionDurationMs fields to JobStatistics. These are already populated in the auto-generated struct receiving the API response, but were not being propagated to this struct. Also update the comment for ReservationUsage based on latest API docs.
product-auto-label
Bot
added
the
api: bigquery
klondikedragon
force-pushed
the
bigquery-jobstats-reservation-id
branch
from
4fa7aaa to
6c5c658
Compare
|
+1, was going to open a feature request for |
shollyman
requested review from
alvarowolfx and
shollyman
and removed request for
whuffman36
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
minor nit on preferring usage of custom types for enum like fields.
| // "STANDARD" - Standard edition. | ||
| // "ENTERPRISE" - Enterprise edition. | ||
| // "ENTERPRISE_PLUS" - Enterprise Plus edition. | ||
| Edition string |
There was a problem hiding this comment.
For those kind of fields, usually we created a custom enum like type to represent the available values, can you change that ?
| Edition string | |
| Edition ReservationEdition |
and add the new enum like type:
// ReservationEdition is used to specify the name of edition corresponding to the reservation.
type ReservationEdition string
var (
// UnspecifiedReservationEdtion is the default value, which will be treated as EnterpriseReservationEdition
UnspecifiedReservationEdition ReservationEdition = "RESERVATION_EDITION_UNSPECIFIED"
// EnterpriseReservationEdition represents the Standard edition.
StandardReservationEdition ReservationEdition = "STANDARD"
// EnterpriseReservationEdition represents the Enterprise edition.
EnterpriseReservationEdition ReservationEdition = "ENTERPRISE"
// EnterprisePlusReservationEdition represents the Enterprise Plus edition.
EnterprisePlusReservationEdition ReservationEdition = "ENTERPRISE_PLUS"
)
Thanks for taking a look @alvarowolfx @klondikedragon I know it's been a while but let us know if you're planning on making the changes. If not I'm happy to as I'm also awaiting these changes. 🙏 |
|
FYI this PR is stale so I think we can close it and merge #12212 🙏 |
|
superseded by #12212 |
|
@ash-ddog thanks for cleaning this up and making the changes! |
3 participants
Add ReservationId, TotalSlotMs, FinalExecutionDurationMs fields to JobStatistics. These are already populated in the auto-generated struct receiving the API response, but were not being propagated to this struct.
Also update the comment for ReservationUsage based on latest API docs.