google-cloud-logging-logback: Allow user to specify custom LoggingOptions#4729
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #4729 +/- ##
============================================
+ Coverage 49.65% 50.07% +0.42%
- Complexity 22771 22816 +45
============================================
Files 2168 2168
Lines 214191 216788 +2597
Branches 24247 24264 +17
============================================
+ Hits 106346 108557 +2211
- Misses 99546 99887 +341
- Partials 8299 8344 +45
Continue to review full report at Codecov.
|
olavloite
force-pushed
the
logback-credentials
branch
from
d10fb93 to
58ad82b
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
WDYT about adding setter method for credential file so user can configure from xml rather than writing code to subclass? |
Contributor
Author
Yes, you are absolutely right. I'll change it to support that. |
kolea2
reviewed
Mar 27, 2019
kolea2
reviewed
Mar 28, 2019
kolea2
approved these changes
Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to subclass com.google.cloud.logging.logback.LoggingAppender to specify custom LoggingOptions, such as custom credentials.
Fixes #3215