Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

fix: table schema change error#692

Merged
Linchin merged 2 commits into
googleapis:mainfrom
Linchin:table-schema
Nov 1, 2023
Merged

fix: table schema change error#692
Linchin merged 2 commits into
googleapis:mainfrom
Linchin:table-schema

Conversation

@Linchin

@Linchin Linchin commented Oct 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #670 🦕

@Linchin Linchin requested review from a team and nayaknishant October 31, 2023 21:29
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Oct 31, 2023
@Linchin Linchin removed the request for review from nayaknishant October 31, 2023 21:33
@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 31, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2023
@Linchin Linchin requested a review from shollyman October 31, 2023 22:12
shollyman
shollyman approved these changes Nov 1, 2023
View reviewed changes

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand on the PR description to be better summarize the change before submission?

Comment thread tests/unit/test_gbq.py Outdated
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2023
@Linchin Linchin merged commit 3dc8ebe into googleapis:main Nov 1, 2023
@Linchin Linchin deleted the table-schema branch November 1, 2023 18:18
@release-please release-please Bot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

attempting to change existing datatype on BQ table through table_schema and if_exists="replace" fails

3 participants

@Linchin @shollyman @yoshi-kokoro