Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

fix: remove pandas-gbq client ID for authentication#927

Merged
tswast merged 2 commits into
mainfrom
tswast-patch-1
Jun 3, 2025
Merged

fix: remove pandas-gbq client ID for authentication#927
tswast merged 2 commits into
mainfrom
tswast-patch-1

Conversation

@tswast

@tswast tswast commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

pandas-gbq's client ID has been failing for some time due to Error 400: redirect_uri_mismatch. Since it's only used for a fallback if no application default credentials are available, it's probably OK to use pydata-google-auth's client ID instead.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

pandas-gbq's client ID has been failing for some time due to `Error 400: redirect_uri_mismatch`. Since it's only used for a fallback if no application default credentials are available, it's probably OK to use pydata-google-auth's client ID instead.
@tswast tswast requested review from a team, Linchin and shuoweil June 3, 2025 15:49
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Jun 3, 2025
@GarrettWu GarrettWu removed their assignment Jun 3, 2025

@mrfaizal mrfaizal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming we're ok removing a fallback option. since it wasn't working anyways, this is no worse than before.

@tswast tswast merged commit 8bb7401 into main Jun 3, 2025
26 checks passed
@tswast tswast deleted the tswast-patch-1 branch June 3, 2025 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants