Skip to content

Fix input cycle validation for non-null lists#4386

Open
andimarek wants to merge 1 commit into
masterfrom
fix-4214-input-list-cycle
Open

Fix input cycle validation for non-null lists#4386
andimarek wants to merge 1 commit into
masterfrom
fix-4214-input-list-cycle

Conversation

@andimarek
Copy link
Copy Markdown
Member

@andimarek andimarek commented May 19, 2026

Summary

Verification

  • Confirmed the new regression test fails on current master with: [self!] forms an unsatisfiable cycle
  • ./gradlew test --tests graphql.schema.validation.NoUnbrokenInputCyclesTest
  • ./gradlew test --tests 'graphql.schema.validation.*'

Fixes #4214

@andimarek andimarek mentioned this pull request May 19, 2026
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5794 (+1 🟢) 5738 (+1 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5794 (+1 🟢) 5737 (+1 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5794 (+1 🟢) 5737 (+1 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5794 (+1 🟢) 5737 (+1 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23208 (+4 🟢) 22981 (+4 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29421 3101 90.5% ±0.0%
Branches 8610 1506 85.1% ±0.0%
Methods 7876 1209 86.7% ±0.0%

Changed Class Coverage (1 class)

Class Line Branch Method
g.s.v.NoUnbrokenInputCycles +2.6% 🟢 +4.4% 🟢 ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-19 00:15:56 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema generator reports false positive unsatisfiable input object cycle

1 participant

@andimarek