Skip to content

Make introspection includeDeprecated arguments non-null#4387

Merged
andimarek merged 1 commit into
masterfrom
fix-3897-non-null-include-deprecated
May 20, 2026
Merged

Make introspection includeDeprecated arguments non-null#4387
andimarek merged 1 commit into
masterfrom
fix-3897-non-null-include-deprecated

Conversation

@andimarek
Copy link
Copy Markdown
Member

@andimarek andimarek commented May 19, 2026

Summary

  • Make all introspection includeDeprecated arguments Boolean! with default false
  • Add Spock coverage for the introspected argument type/default and explicit null rejection

Fixes #3897

Spec change: graphql/graphql-spec#1142

Tests

  • ./gradlew test --tests graphql.introspection.IntrospectionTest
  • ./gradlew test --tests graphql.introspection.IntrospectionResultToSchemaTest --tests graphql.introspection.IntrospectionJsonBugTest --tests graphql.StarWarsIntrospectionTests --tests graphql.validation.RulesVisitorTest --tests graphql.normalized.ExecutableNormalizedOperationToAstCompilerTest --tests graphql.introspection.IntrospectionWithDirectivesSupportTest

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5799 (+6 🟢) 5743 (+6 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5799 (+6 🟢) 5742 (+6 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5799 (+6 🟢) 5742 (+6 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5799 (+6 🟢) 5742 (+6 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23228 (+24 🟢) 23001 (+24 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29422 3102 90.5% ±0.0%
Branches 8611 1507 85.1% ±0.0%
Methods 7876 1209 86.7% ±0.0%

No per-class coverage changes detected.

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-19 00:21:28 UTC

@andimarek andimarek added the breaking change requires a new major version to be relased label May 19, 2026
@andimarek
Copy link
Copy Markdown
Member Author

andimarek commented May 19, 2026

Stricly speaking a breaking change, but because it is a spec change we can/should ship in a minor release @bbakerman @dondonz ?

@andimarek andimarek mentioned this pull request May 19, 2026
Closed
@andimarek andimarek merged commit 1fce25b into master May 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees

No one assigned

Labels

breaking change requires a new major version to be relased

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spec change: Make includeDeprecated non nullable in introspection

2 participants

@andimarek @bbakerman