Skip to content

Allow empty unions to be completed by extensions#4388

Open
andimarek wants to merge 1 commit into
masterfrom
test-4200-empty-union-base
Open

Allow empty unions to be completed by extensions#4388
andimarek wants to merge 1 commit into
masterfrom
test-4200-empty-union-base

Conversation

@andimarek
Copy link
Copy Markdown
Member

Summary

Fixes #4200

Testing

  • ./gradlew test --tests graphql.schema.idl.SchemaGeneratorTest --tests graphql.schema.idl.SchemaTypeCheckerTest

@github-actions
Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5824 (+2 🟢) 5768 (+2 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5824 (+2 🟢) 5767 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5824 (+2 🟢) 5767 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5824 (+2 🟢) 5767 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23328 (+8 🟢) 23101 (+8 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29497 3131 90.4% ±0.0%
Branches 8657 1533 85.0% ±0.0%
Methods 7883 1210 86.7% ±0.0%

Changed Class Coverage (1 class)

Class Line Branch Method
g.s.i.UnionTypesChecker ±0.0% +7.1% 🟢 ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-19 06:11:24 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty union base definitions rejected before extensions are merged (spec violation)

1 participant