Make snapshots region aware#742
Merged
Merged
Conversation
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
ludfjig
force-pushed
the
snapshot
branch
2 times, most recently
from
e7ab5a3 to
a9486f4
Compare
ludfjig
added
the
kind/enhancement
syntactically
previously approved these changes
Jul 30, 2025
Member
Can we get this done before the next release? |
ludfjig
force-pushed
the
snapshot
branch
2 times, most recently
from
11084ba to
93612a2
Compare
dblnz
previously approved these changes
Jul 30, 2025
- Accept iterator instead of slice - Move function from trait to module level. Necessary to maintain object safety of Hypervisor trait Signed-off-by: Ludvig Liljenberg <[email protected]>
- Separate Vecs for initial sandbox regions and mmap regions - Replace unmap_regions(n) with unmap_region(region) for precise control - Add Hash derive for MemoryRegion and related types - Enable use of MemoryRegino in HashSet for efficient set operations Signed-off-by: Ludvig Liljenberg <[email protected]>
- Snapshot now contains the memory region that were mapped at the time of snapshot - On restore, unmap regions that were not mapped at time of snapshot. Map regions that were - Add simple test Signed-off-by: Ludvig Liljenberg <[email protected]>
simongdavies
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that when restoring to a snapshot, memory region that were mapped when the snapshot was taken, will be remapped if they have been unmapped since.
Will add a follow up pr for making sure snapshots "belong" to a particular sandbox, and can not be used to restore different sandbox.