refactor(autoreview): Extract PHPUnit test analysis into a dedicated helper#3279
Merged
Merged
Conversation
Member
Author
|
@coderabbitai full reveiw |
|
✅ Action performedFull review finished. |
📝 WalkthroughWalkthroughThis PR refactors PHPUnit test detection in architecture tests by extracting integration-group identification from ChangesPHPUnit detection refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
theofidry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Future PHPat rules will need more PHPUnit-related information from PHPStan
ClassReflectionobjects.This PR takes the first step by extracting existing PHPUnit-specific checks into a reusable helper,
PHPUnitTestClassAnalysis. The goal is not to reduce much code immediately, but to make the intent explicit and keep the next behaviour changes small and easier to review.Changes
Adds
PHPUnitTestClassAnalysis, which:ClassReflectionrepresents a PHPUnit test case.#[Group('integration')]attribute parsing out ofPHPUnitTestIoRequirements.The PHPUnit test-case check is intentionally unchanged for now. It remains a small wrapper around the existing logic so that later fixes can be reviewed as behaviour changes, rather than being mixed into this extraction.
Reviewer Notes
This PR is intended as a refactor with no behaviour change.
This is a small step to untangle #3277 which itself is a PR made to untangle things. It's partly about refining the modelisation of our rules with PHPat and partly adjusting AI generated code I previously did not care as much about.