Skip to content

Johnny Burke, Kiyohide Hayashi - Berlin - W1D1 Lab#609

Closed
JohnnyAL wants to merge 1 commit into
ironhack-labs:masterfrom
JohnnyAL:master
Closed

Johnny Burke, Kiyohide Hayashi - Berlin - W1D1 Lab#609
JohnnyAL wants to merge 1 commit into
ironhack-labs:masterfrom
JohnnyAL:master

Conversation

@JohnnyAL

@JohnnyAL JohnnyAL commented Jan 6, 2020

Copy link
Copy Markdown

No description provided.

Comment thread js/index.js
console.log(`The driver's name is ${hacker1}`);
let hacker2 = "Kiyo";
console.log(`The navigator's name is ${hacker2}`);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! No comments on this iteration

Comment thread js/index.js
} else {
console.log(`It seems that the navigator has the longest name, it has ${hacker2.length} characters.`);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job as well here! All good
On a small note, on the conditionals, try to leave the else condition for the "===" in this case, and the other if statements for the "<" and ">" options. As I said the code is still good but it could be more readable for other partners the other way.

Comment thread js/index.js
}

console.log(navNameReverse);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good in this iteration!
No comments :D

Comment thread js/index.js
console.log("Yo, the navigator goes first definitely.");
} else {
console.log("What?! You both have the same name?");
} No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good as well here!
No comments! :D

@stale

stale Bot commented Feb 6, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Feb 6, 2020
@stale

stale Bot commented Feb 8, 2020

Copy link
Copy Markdown

This pull request is closed. Thank you.

@stale stale Bot closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants