Fix bug in AstList add (fixes #356)#423
Merged
Merged
Conversation
We do this first so that the material change is evident.
Member
Author
|
I see why we do not simply use a |
Member
Author
|
There are other problems in the affected code (see #356 (comment)), but I don't propose to fix them in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first material change fixes the bug reported in #356, but there are others in
AstListthat prevent it behaving as a Pythonlist. (Try slice assignment.) Maybe we should fix those too.Generally, I'm puzzled why this isn't just a
PyList.