CLOUDSTACK-8066: There is not way to know the size of the snapshot created.

sanjaytripathi · sanjaytripathi · commit 9153b8bede33 · 2014-12-17T16:00:19.000+05:30
diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -613,6 +613,7 @@ public class ApiConstants {
     public static final String REGION_LEVEL_VPC = "regionlevelvpc";
     public static final String STRECHED_L2_SUBNET = "strechedl2subnet";
     public static final String NETWORK_SPANNED_ZONES = "zonesnetworkspans";
+    public static final String PHYSICAL_SIZE = "physicalsize";
 
     public enum HostDetails {
         all, capacity, events, stats, min;
diff --git a/api/src/org/apache/cloudstack/api/response/SnapshotResponse.java b/api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
@@ -86,6 +86,10 @@ public class SnapshotResponse extends BaseResponse implements ControlledEntityRe
     @Param(description = "the state of the snapshot. BackedUp means that snapshot is ready to be used; Creating - the snapshot is being allocated on the primary storage; BackingUp - the snapshot is being backed up on secondary storage")
     private Snapshot.State state;
 
+    @SerializedName(ApiConstants.PHYSICAL_SIZE)
+    @Param(description = "physical size of backedup snapshot on image store")
+    private long physicalSize;
+
     @SerializedName(ApiConstants.ZONE_ID)
     @Param(description = "id of the availability zone")
     private String zoneId;
@@ -166,6 +170,10 @@ public void setState(Snapshot.State state) {
         this.state = state;
     }
 
+    public void setPhysicaSize(long physicalSize) {
+        this.physicalSize = physicalSize;
+    }
+
     @Override
     public void setProjectId(String projectId) {
         this.projectId = projectId;
diff --git a/engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotInfo.java b/engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotInfo.java
@@ -36,4 +36,6 @@ public interface SnapshotInfo extends DataObject, Snapshot {
     ObjectInDataStoreStateMachine.State getStatus();
 
     boolean isRevertable();
+
+    long getPhysicalSize();
 }
diff --git a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
@@ -138,6 +138,16 @@ public boolean isRevertable() {
         return false;
     }
 
+    @Override
+    public long getPhysicalSize() {
+        long physicalSize = 0;
+        SnapshotDataStoreVO snapshotStore = snapshotStoreDao.findBySnapshot(snapshot.getId(), DataStoreRole.Image);
+        if (snapshotStore != null) {
+            physicalSize = snapshotStore.getPhysicalSize();
+        }
+        return physicalSize;
+    }
+
     @Override
     public VolumeInfo getBaseVolume() {
         return volFactory.getVolume(snapshot.getVolumeId());
diff --git a/server/src/com/cloud/api/ApiResponseHelper.java b/server/src/com/cloud/api/ApiResponseHelper.java
@@ -493,6 +493,7 @@ public SnapshotResponse createSnapshotResponse(Snapshot snapshot) {
             snapshotResponse.setRevertable(false);
         } else {
         snapshotResponse.setRevertable(snapshotInfo.isRevertable());
+        snapshotResponse.setPhysicaSize(snapshotInfo.getPhysicalSize());
         }
 
         // set tag information

Original file line number	Diff line number	Diff line change
`@@ -36,4 +36,6 @@ public interface SnapshotInfo extends DataObject, Snapshot {`
`36`	`36`	`ObjectInDataStoreStateMachine.State getStatus();`
`37`	`37`
`38`	`38`	`boolean isRevertable();`
	`39`	`+`
	`40`	`+ long getPhysicalSize();`
`39`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -493,6 +493,7 @@ public SnapshotResponse createSnapshotResponse(Snapshot snapshot) {`
`493`	`493`	`snapshotResponse.setRevertable(false);`
`494`	`494`	`} else {`
`495`	`495`	`snapshotResponse.setRevertable(snapshotInfo.isRevertable());`
	`496`	`+ snapshotResponse.setPhysicaSize(snapshotInfo.getPhysicalSize());`
`496`	`497`	`}`
`497`	`498`
`498`	`499`	`// set tag information`