add more unit tests

bentsku · bentsku · commit aa9383f01ca9 · 2025-09-24T10:27:29.000+02:00
diff --git a/tests/unit/aws/protocol/test_serializer.py b/tests/unit/aws/protocol/test_serializer.py
@@ -765,6 +765,7 @@ def test_json_protocol_error_serialization_with_shaped_default_members_on_root()
 
 
 def test_json_protocol_error_serialization_empty_message():
+    # if the exception message is not passed, an empty message will be passed as an empty string `""`
     exception = TransactionCanceledException()
 
     response = _botocore_error_serializer_integration_test(
@@ -778,6 +779,45 @@ def test_json_protocol_error_serialization_empty_message():
     assert "message" not in response
 
 
+@pytest.mark.parametrize("empty_value", ("", None))
+def test_json_protocol_error_serialization_empty_non_required_members(empty_value):
+    # if the exception message is not passed, an empty message will be passed as an empty string `""`
+    exception = TransactionCanceledException()
+
+    response = _botocore_error_serializer_integration_test(
+        "dynamodb",
+        "ExecuteTransaction",
+        exception,
+        "TransactionCanceledException",
+        400,
+        "",
+    )
+    assert "message" not in response
+
+
+@pytest.mark.parametrize("empty_value", ("", None))
+def test_json_protocol_error_serialization_with_empty_non_required_members(empty_value):
+    class _ResourceNotFoundException(ServiceException):
+        code: str = "ResourceNotFoundException"
+        sender_fault: bool = True
+        status_code: int = 404
+        ResourceType: str | None
+        ResourceId: str | None
+
+    exception = _ResourceNotFoundException("Not Found", ResourceType="")
+
+    response = _botocore_error_serializer_integration_test(
+        "arc-region-switch",
+        "ApprovePlanExecutionStep",
+        exception,
+        "ResourceNotFoundException",
+        404,
+        "Not Found",
+        protocol="json",
+    )
+    assert "ResourceType" not in response
+
+
 @pytest.mark.parametrize("empty_value", ("", None))
 def test_json_protocol_error_serialization_with_empty_required_members(empty_value):
     class _ResourceNotFoundException(ServiceException):
@@ -801,7 +841,7 @@ class _ResourceNotFoundException(ServiceException):
     if empty_value is not None:
         expected_exception_values["resourceId"] = ""
 
-    _botocore_error_serializer_integration_test(
+    response = _botocore_error_serializer_integration_test(
         "verifiedpermissions",
         "IsAuthorizedWithToken",
         exception,
@@ -810,6 +850,7 @@ class _ResourceNotFoundException(ServiceException):
         "Exception message!",
         **expected_exception_values,
     )
+    assert "" not in response
 
 
 def test_rest_json_protocol_error_serialization_with_additional_members():
@@ -996,6 +1037,29 @@ class AccessDeniedException(ServiceException):
     )
 
 
+@pytest.mark.parametrize("empty_value", ("", None))
+def test_rpc_v2_cbor_protocol_error_serialization_with_empty_non_required_members(empty_value):
+    class _ResourceNotFoundException(ServiceException):
+        code: str = "ResourceNotFoundException"
+        sender_fault: bool = True
+        status_code: int = 404
+        ResourceType: str | None
+        ResourceId: str | None
+
+    exception = _ResourceNotFoundException("Not Found", ResourceType="")
+
+    response = _botocore_error_serializer_integration_test(
+        "arc-region-switch",
+        "ApprovePlanExecutionStep",
+        exception,
+        "ResourceNotFoundException",
+        404,
+        "Not Found",
+        protocol="smithy-rpc-v2-cbor",
+    )
+    assert "ResourceType" not in response
+
+
 def test_json_protocol_content_type_1_0():
     """AppRunner defines the jsonVersion 1.0, therefore the Content-Type needs to be application/x-amz-json-1.0."""
     service = load_service("apprunner")
