Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

DynamoDB: refactor the store for proper type annotations#13256

Merged
giograno merged 3 commits into
mainfrom
avro-ddb
Feb 12, 2026
Merged

DynamoDB: refactor the store for proper type annotations#13256
giograno merged 3 commits into
mainfrom
avro-ddb

Conversation

@giograno

@giograno giograno commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

This PR improves the annotations and the structure of the DDB store, needed for our new serialization framework.

Changes

  • Fix the type annotations for some DDB store attributes (e.g, GLOBAL_TABLES);
  • Pulling out streaming destination descriptions for the table_definition attribute. In this way, we could easily reuse the generated TypedDict for annotations.
  • Introduce a Backup dataclass, wrapping BackupDetails with other additional information.
  • Correspondent provider adjustements.

@giograno giograno self-assigned this Oct 13, 2025
@giograno giograno added docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Oct 13, 2025
@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 111 tests  +12   21 249 ✅ +12   6m 5s ⏱️ -9s
     1 suites ± 0    1 862 💤 ± 0 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 4cc822a. ± Comparison against base commit 2046dff.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files      2 suites   56m 19s ⏱️
1 989 tests 1 876 ✅ 113 💤 0 ❌
1 991 runs  1 876 ✅ 115 💤 0 ❌

Results for commit 4cc822a.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results - Alternative Providers

92 tests   - 1 181   86 ✅  - 640   6m 47s ⏱️ - 24m 19s
 1 suites  -     3    6 💤  - 541 
 1 files    -     3    0 ❌ ±  0 

Results for commit 4cc822a. ± Comparison against base commit 2046dff.

This pull request removes 1181 tests. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_autoexpand_capability_requirement
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_non_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_update_refreshes_template_metadata
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_create_existing
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_invalid_params
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_missing_stackname
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_no_changes
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_nonexisting
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_without_parameters
…

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4cc822a. ± Comparison against base commit 2046dff.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 18m 45s ⏱️ - 1h 17m 15s
2 013 tests  - 3 599  1 903 ✅  - 3 201  110 💤  - 398  0 ❌ ±0 
2 019 runs   - 3 599  1 903 ✅  - 3 201  116 💤  - 398  0 ❌ ±0 

Results for commit 4cc822a. ± Comparison against base commit 2046dff.

This pull request removes 3599 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@giograno giograno added this to the Playground milestone Nov 21, 2025
@giograno giograno changed the title DDB: add types and TaggingService DynamoDB: refactor the store for proper type annotations Feb 11, 2026
@giograno giograno requested review from bentsku February 12, 2026 10:11
@giograno giograno marked this pull request as ready for review February 12, 2026 10:16
viren-nadkarni
viren-nadkarni approved these changes Feb 12, 2026
View reviewed changes

@viren-nadkarni viren-nadkarni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread localstack-core/localstack/services/dynamodb/provider.py Outdated
Comment thread localstack-core/localstack/services/dynamodbstreams/models.py Outdated
@giograno

giograno commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review. I addressed both comments in the last commit.

@giograno giograno merged commit 58d61f3 into main Feb 12, 2026
56 of 57 checks passed
@giograno giograno deleted the avro-ddb branch February 12, 2026 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bentsku bentsku Awaiting requested review from bentsku

1 more reviewer

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@giograno giograno

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

2 participants

@giograno @viren-nadkarni