Merge release/6.5 into master#1636
Merged
Merged
Conversation
Improved the existing `testSQL` and added tests for no rows being returned.
DEVEXP-668 Added test for fromSql with no rows returned
Not sure why `output` was ever set to `execute` - removing it does not cause any breaks on MarkLogic 11.1, and the 11-nightly (properly) throws an error when it's included. So removing it.
Removing buggy usage of `execute`
For SSL and/or certificate authentication. Same approach as for a keystore, just for a truststore. Was able to reuse and improve `TwoWaySSLTest` by modifying it to use the key store as a trust store instead of using a "trust everything" trust manager.
Will submit a separate PR if/when the REST API is updated to throw a nicer error message.
MLE-4119: User can now submit an Optic update plan
MLE-4116: Can now configure trust store
Improved error message when Optic update plan fails
…message" This reverts commit dd2e861.
…date" This reverts commit e4a7eaf.
Reverting usage of v1/rows/update
Moved a brittle test to get it out of the PR test suite.
Bumped dependencies
Now using separate key and trust stores.
Improved 2-way SSL test
This test was expecting to fail because of a previous bug that was fixed back November.
BillFarber
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.