-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Soft-deprecate dashes in favor of linestyle #17483
Copy link
Copy link
Open
Labels
API: changesChanges to the public API, typically requiring deprecation.Changes to the public API, typically requiring deprecation.keepItems to be ignored by the “Stale” Github ActionItems to be ignored by the “Stale” Github Action
Milestone
Metadata
Metadata
Assignees
Labels
API: changesChanges to the public API, typically requiring deprecation.Changes to the public API, typically requiring deprecation.keepItems to be ignored by the “Stale” Github ActionItems to be ignored by the “Stale” Github Action
Type
Fields
Give feedbackNo fields configured for issues without a type.
dashes are just a more limited form of linestyles. Actually, they are no more than:
I propose to soft-deprecate dashes in favor of linestyle. Dashes are redundant and thus only increase the API complexity without any benefit. OTOH I don't think we should deprecate dashes because there might be quite a bit of code out there using it.
Specific actions for this task:
linestyleshould directly accept a dash pattern. - It currently only accepts(offset, dash_pattern).set_linestyle.set_dashes, recommend to useset_linestyleinstead.